Skip to content

Keep the first decode error in sandboxwire.Decoder #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Oct 6, 2026
Merged

Keep the first decode error in sandboxwire.Decoder #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
300 changes: 106 additions & 194 deletions apps/daemon/internal/processshim/ipc.go
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 2 additions & 23 deletions apps/daemon/internal/processshim/ipc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,12 @@ package processshim
import (
"bytes"
"encoding/binary"
"encoding/hex"
"errors"
"os"
"path/filepath"
"reflect"
"strings"
"testing"

"github.com/MiniMax-AI/OpenAgentCore/internal/sandboxwire"
"github.com/MiniMax-AI/OpenAgentCore/internal/sandboxwire/sandboxwiretest"
)

func b(s string) []byte { return []byte(s) }
Expand Down Expand Up @@ -75,28 +72,10 @@ func decoderFor(t uint16) func(sandboxwire.Frame) (Message, error) {
return decoders[min(t>>4, 2)]
}

func readHexFixture(t testing.TB, name string) []byte {
t.Helper()
raw, err := os.ReadFile(filepath.Join("testdata", name))
if err != nil {
t.Fatal(err)
}
var digits strings.Builder
for _, line := range strings.Split(string(raw), "\n") {
line, _, _ = strings.Cut(line, "#")
digits.WriteString(strings.Join(strings.Fields(line), ""))
}
frame, err := hex.DecodeString(digits.String())
if err != nil {
t.Fatal(err)
}
return frame
}

func TestGoldenFixtures(t *testing.T) {
for _, fx := range fixtures {
t.Run(fx.name, func(t *testing.T) {
want := readHexFixture(t, fx.name)
want := sandboxwiretest.ReadHex(t, fx.name)
var got bytes.Buffer
if err := sandboxwire.WriteFrame(&got, Frame(fx.msg)); err != nil {
t.Fatal(err)
Expand Down
Loading
Loading