Repository navigation
Delete the empty installation configuration fields - #500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /core/v1/installationreturnedconfiguration.path,apply_commandandapplied_atas"",""andnullevery time. Core reports the process settings it loaded and never sets them, and their only producer was the parser deleted in #499.configurationitself was declared nullable, but Core always sets it and exits at startup if it can't build it.InstallationConfigurationnow holds onlysettings, andInstallation.Configurationis a non-null value.core.openapi.yamlis regenerated withmake openapi.configurationmust be an object with onlysettings.admin-api.md,docs/web/console-api-usage.md(and zh),apps/web/DESIGN.mdandPRODUCT.md. The latter two dropped stale claims that Web shows a copyable config path and apply command.No blind review: the change only deletes fields that are always empty or never null.
Checks:
go build ./...,go vet ./services/core/..., the installation API andcmd/servertests.make openapi(left no diff),make check-docs,check-names.py, translation test.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.