Repository navigation
Classify node readiness without vendor codes - #540
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node readiness is reported in six Provider-neutral classes instead of vendor-named codes.
docker_unavailableprovider_unavailabledocker_limits_unsupported,kvm_unavailablehost_unsupportedmicrosandbox_artifacts_unavailableartifacts_unavailableruntime_download_failed,runtime_image_unavailableandcapacity_insufficientare unchanged.node_diagnostic.gostays the one authored list. Thesandboxpackage exports one error per class. Probes wrap the class error and keep the vendor detail in the local error text, which never crosses the transport. The vendor-named errors are gone.make openapi), the agents-client list and normalizer, and Web's per-class advice and locales. The advice is Provider-neutral and points to the installer preflight and node logs for the local detail.000095_node_readiness_classes.sqlrewrites stored codes to their classes, so no API response can return a removed code. The node wire protocol version is unchanged, because the field stays a string with the same validation.node-generation-protocol.md,sandbox-deployment.md,getting-started/nodes.mdandweb/console-api-usage.md. The protocol doc now matches the code: a frame whosediagnosticis not a declared class is invalid.Checks:
go build,go vet; Go tests forsandbox,sandbox/node,sandbox/providers,deployment/...,cmd/sandbox-nodeanddeploymentpgagainst a database, including the migration test;make openapiwith no extra diff; agents-client typecheck and tests; Web typecheck and the sandbox and lib vitest files;check-names; translations. The live Docker transport test was skipped (no fixture image).e2e/nodes.spec.tsis updated and left to CI.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.