Repository navigation
Keep vendor node settings in the adapter - #543
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each node adapter now owns its node-local settings and code. The shared
providerspackage keeps only the generic node path.Node configuration.
{provider, generation, installation_id, core_url, specification, native}.nativeis opaque JSON that only the selected adapter decodes, strictly. Resources, the image and artifact hashes are read fromspecification, never copied.docker: {host, image, network, seccomp_file, extra_hosts, nested_sandbox}native: {host, image, network, seccomp_file, extra_hosts, nested_sandbox}microsandbox: {helper_path, runtime_path, firmware_path, runtime_home, network, runtime_sha256, firmware_sha256, image, cpus, memory_mib, root_disk_mib, environment_disk_mib}native: {helper_path, runtime_path, firmware_path, runtime_home, network}A file in the old shape is invalid.
Docker image.
imagestays node-local: a classic image store names the loaded image by its config digest (image_id), a containerd store by its manifest digest. The check that it equals one of the two now lives in the Docker adapter's decoder.Protocol (
sandbox_provider.go,docs/sandbox-provider.md):NodeConfig,LocalOptionsandBuiltmove into the protocol file.BuildLocaltakessandbox.NodeConfig.Moves.
providers/docker.go→docker/node.go.providers/microsandbox.goand the microsandbox probe →microsandbox/node.goandmicrosandbox/probe.go; the native artifacts are exported asmicrosandbox.NodeArtifacts.BackendFingerprintandCheckCapacity→ thesandboxpackage.providerskeepsLoad(strict envelope),Buildand the registry list.Deleted. The specification cross-checks (
providers/specification.go), the name-based "both objects" check, and the installer's mirror and stale-key checks.Behaviour.
nativefails at Build instead of Load.sameGenerationPlancompares only the Core-visible envelope: preparation may resolve node-local settings, and the adapter validates them when it builds. The Python preparer still requires plan and final to match, except for the Docker image within the release's two digests.Installer.
provider_config,node_spec,node_generationsandremove_node_fileswrite and readnative.Docs (en and zh):
configuration.md#docker-node-configuration,getting-started/nodes.md(manual registration) andsandbox-provider.md.Checks:
go build,go vetand gofmt.sandbox/...andcmd/sandbox-node.cmd/server,api,deployment,placement,execution,deploymentpg,modelconfigurationpg,sessionpgandtests/integrationagainst a database.deploy/nodeunittest and pytest, pluspy_compile.provider-artifactsandspecification-contract(no projection change).check-names,make check-docsand translations.Net: non-test −25, test +15, docs +4.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.