Repository navigation
Author closed sets as typed constants - #560
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core closed sets were repeated in producers, schema tags and generated client constants, allowing strict response validators to drift from real responses. Define them with typed Go constants at their existing owners, use those constants in producers and validators, and regenerate shared OpenAPI/TypeScript enum references. Reuse the model-provider protocol definition and check the retained official/Runtime diagnostic tags against their owners.
Wire values, required fields, nullability and stored data are unchanged; all three normalized reachable API schemas match the baseline. Runtime observation and allocation tags remain for the coordinated cutover follow-up.
Validation: whole-module build/vet; changed and dependent Go packages (including PostgreSQL); focused database integration and schema contract tests; client/Web typechecks and focused unit tests; OpenAPI generation/freshness, generator tests, documentation checks and naming guard. Coordinator reviewed the complete diff.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.