Repository navigation
Prepare required MiniMax workspace tools before execution - #621
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax Code could report successful preparation after its required workspace MCP bridge timed out, leaving the model without workspace tools. Session creation and loading now use the existing scoped native MCP connection to discover and validate the generated workspace tool inventory before preparation succeeds. Optional MCP remains lazy and the existing discovery deadline is unchanged.
The private native handshake and its consumer are updated together. The tool inventory is generated from the existing worker description; no Core path, public API, setting, or second execution loop is added.
Validation: Go adapter tests, vet, cancellation race ×50, native MCP/prompt regressions, build-script syntax, hygiene, and independent blind review passed. Controlled ACP tests reproduce missing tools before this change and cover preparation failure, connection reuse, and optional MCP afterward. Full companion build and live lifecycle qualification remain pending in the coordinated distribution batch; this does not yet establish the cause or resolution of the previous live failure.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.