Repository navigation
Prepare required workspace through native connection pool - #623
Merged
SaladDay merged 2 commits intoOct 9, 2026
Merged
Conversation
SaladDay
deleted the
aos/prepare-required-workspace-through-native-pool
branch
October 9, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required workspace preparation used the native Turn discovery helper, whose short timeout returns an empty inventory after a failed attempt. Preparation now discovers and validates the bridge through the existing Session-scoped connection pool, with the native connection timeout and the unchanged ACP/Core deadlines. Turn discovery and optional MCP lazy connections retain their existing behavior.
The change also records safe native preparation phase, duration and outcome fields without logging native errors or credentials.
Validation: native pool/SDK lifecycle and prompt regressions pass, including readiness beyond the shortened Turn threshold, configured timeout, interrupted initialization, configuration cleanup and selected-server reconnection. Go Mcode tests/vet and name, documentation and CI checks pass. The baseline fails the new startup-budget regression. The cached native build and matching 500 ms File-service prepare-only comparison pass: ready at 74.621 s, native MCP connect 15.201 s, zero model requests, and confirmed owner shutdown. The baseline failed Session creation at 15.236 s. File calls remain 192 in both cases; this is a correctness fix, not a latency optimization. Live acceptance remains pending.
Native service shutdown joins initialization and mutation cleanup; final process containment remains owned by the Executor/View. This corrects startup discovery semantics and does not establish the cause of the earlier live failure.