Repository navigation
Start Mcode workspace worker directly - #624
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mcode workspace calls start the native worker directly, removing the intermediate Node launcher. The bridge reads its private profile once; ToolExecutor validates the canonical workspace and creates scratch at initialization, then uses that workspace for each worker's arguments and cwd. Invalid profiles fail initialization. Worker code, per-call input/output limits, cancellation and close settlement remain unchanged. Packaging no longer includes the launcher.
A controlled real File/Session View comparison used the same native worker and one workspace read per call, with three calls per variant at each delay. Each call dropped from 89 to 72 File RPCs and from two to one Node child starts. At 100 ms injected delay per File operation, median tool latency decreased from 9962.08 ms to 8210.23 ms (17.6%); at 0 ms, medians were 954.53 ms and 955.35 ms, showing no credible latency improvement. This measures local tool execution, not model/API latency or live provider qualification.
Validation:
The standalone artifact checker stopped at its existing
which rgprerequisite in the split agent-host image, which expects rg in the sandbox. That checker and the subsequent packaged large-output test are not reported as passed. No native rebuild or live validation was performed for this change; integrated packaging and qualification remain in the common build batch.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.