Repository navigation
Read bounded trees through File handles - #625
Merged
SaladDay merged 2 commits intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment finalization traverses and reads each package through many individual File requests. Add the declared
OpenTreeoperation and stream its bounded, read-only result through existingRead/Releasehandles. Preserve both readbacks, package validation, object identity, permissions and existing installation limits. Pending acquisition and descriptor-use joins make cancellation, repeated Release and shutdown settle resources before reporting cleanup.With the unchanged composition fixture, finalization drops from 393 to 165 RPCs. Single baseline/candidate samples at 20/100 ms per-handler delay improve from 4.797/23.621 s to 2.225/10.996 s. Go allocations decrease, but the result adds temporary memfd backing and serialization: at most four results per service, one per attachment and 128 MiB reserved backing total. No cache, fallback, setting or timeout change.
Validation: six related packages, protocol/fileservice race suites, focused race ×20, codec fuzz, vet, naming/docs/CI and translation checks passed. Nineteen privileged/native/FUSE tests require unavailable prerequisites and were skipped. The official runtime image passed local Docker memfd/sealing checks; live micro lifecycle qualification remains outstanding. Measurements do not establish peak-memory savings or closure of the live initialization failure.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.