Skip to content

Pipeline workspace artifact exports - #626

Merged
SaladDay merged 2 commits into
aos/cutoverfrom
aos/pipeline-workspace-artifact-exports
Oct 9, 2026
Merged

SaladDay merged 2 commits into
aos/cutoverfrom
aos/pipeline-workspace-artifact-exports

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Completed Turns wait for output Artifact capture, whose sequential File reads amplify remote latency. Export files in batches of at most four and the declared handle limit, with one ordered tar writer. Preserve file size/mtime validation, symlink handling, all export bounds, and descriptor identity; cancel and join the batch on errors and settle handles before releasing owner references.

A seven-file real File fixture preserves byte-identical archives and all 41 RPCs, while 20/100 ms injected handler latency falls about 36.6%. Zero-delay samples show no reliable improvement; cumulative Go allocations increase by roughly 80 KiB. Readers hold at most one bounded File response each and share a 32 KiB copy buffer per batch, without whole-file buffering. Measurements precede the final error-cleanup cancellation follow-up; successful scheduling is unchanged. Live latency is not yet requalified.

Validation: focused agenthost/dispatch tests, relevant race tests ×20, exact 200 MiB streaming and advertised handle limits 1–4, failure/cancellation/late-acquisition cleanup, vet, check-names, check-docs and check-ci. Independent full-diff review found one cancellation issue; corrected with a three-line change and an asymmetric blocked-read regression (old fails, correction passes race ×20). No other substantive findings.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit 224caba into aos/cutover Oct 9, 2026
20 checks passed
@SaladDay
SaladDay deleted the aos/pipeline-workspace-artifact-exports branch October 9, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant