Repository navigation
Offer the installation's Runtime after an upgrade - #703
Merged
Merged
Conversation
SaladDay
force-pushed
the
offer-the-installations-runtime-after-an-upgrade
branch
from
October 14, 2026 13:25
2f45d3f to
61656fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a Docker or microsandbox deployment's saved Runtime differs from the Runtime this console serves (
/node-install/manifest.json), Settings → Sandbox and scheduling shows a Runtime row with both source commits (12 characters) and the action Use this installation's Runtime. The action opens the existing Change resources dialog on its review step with the served Runtime. Save configuration sends it through the existingPUT /core/v1/sandbox/deployment. Core then stores a new generation, and the page's Configuration rollout takes over. When the two Runtimes match, when the console serves no manifest, or during a reset, nothing new is shown.SandboxDeploymentSettings.tsx: reads the served release only when the deployment has a savedspecification.runtime, compares all six release fields, and shows the row with its action.SandboxSetupWizard.tsx: new optionalproposedRuntimeprop. It seeds the edited Runtime and opens on the review step. Its only caller is the new action.sandbox-queries.ts: the wizard's inline manifest query becomes a shareddistributionRuntimeQuery, used by the wizard and Settings. There is no new route or field.settings.css:.settings-row-contentusesflex: 1 1 auto, so a long row value wraps its action onto the next line on phones instead of squeezing the text. Short values stay inline.apps/web/PRODUCT.md: Online sandbox configuration.docs/getting-started/nodes.md(Change the sandbox configuration) anddocs/web/console-api-usage.md, each in EN and zh, with refreshedsource_hash.Why
After the test cluster was upgraded, moving the microsandbox deployment to the new Runtime meant typing six identities by hand under Advanced settings. The saved Runtime always won, and Web never said that the console serves a different one.
Premises checked in code
/node-install/manifest.jsonthroughdistributionRuntime.services/webserves it from the release thatnode-payload/active.jsonpoints to.ClassifyChangeandUpdate(internal/deployment/execution.go) store the next generation and retain the previous one. Rollout then reportspreparing.DeploymentPolicy.Runtimeis false for E2B. Core rejectsruntimefor it, anddeploymentContract.providers.e2b.runtimeisfalse. The row needs a savedspecification.runtime, so it never appears for E2B, and Settings never requests the manifest for it.nodes.spec.tstest "edits only the saved backend, preserving a custom size and Runtime" still passes, and now runs with the row visible.Verification
pnpm --filter @oac/web typecheck: passed.vitest runon the sandbox wizard, queries, rollout summary, deployment specification and page ownership tests, plus the i18n test: 37 of 37 passed. The rollout summary test now wrapsSandboxDeploymentSettingsin aQueryClientProvider.sandbox-generation.spec.ts: 9 of 9 passed, including the new test (saved Runtime A, served Runtime B; the row is shown, the action sends B, the row disappears and preparation starts).nodes,unified-settings,sandbox-lifecycle,sandbox-rollout-detailsandsandbox-resetspecs: 33 of 33 passed.pnpm --dir website buildandpnpm --dir website test: 22 of 22 passed, including the translation hashes and link checks.make check-namesandmake check-docs: both passed.Skipped
make checkand the full Web unit and acceptance suites (only focused checks were run).Need help on this PR? Tag
@codesmith-botwith what you need.