Repository navigation
Wrap startup setting names only at underscores - #705
Merged
Merged
Conversation
The shared code style lets text break anywhere, so on phones the Startup settings table shrank the name column and split names mid-word (OAC_EXECUTIO N_CONCURRE NCY). Names now break only at the existing <wbr> after each underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings → Service and deployment → Startup settings split variable names mid-word on phones (
OAC_EXECUTIO N_CONCURRE NCY), because the shared.system-codestyle setsoverflow-wrap: anywhereand the table shrinks the name column to that minimum. The names now break only at the existing<wbr>after each underscore; desktop is unchanged and the page has no horizontal overflow at 390 px.Checks:
pnpm --filter @oac/web typecheck; fixture console screenshots at 390 px (zh, en) and 1440 px (zh).Need help on this PR? Tag
@codesmith-botwith what you need.