Repository navigation
ci: adopt bcgov/actions/pr-validate for centralized workflow linting - #791
Conversation
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. Three lines of CI change: a SHA-pinned third-party action, one added I verified against the file rather than vibes: One thing I could not verify from inside this sandbox (no network fetch of 📊 Overall: Like a fix PR that just fixes the thing and touches nothing else — a unicorn sighting in production. I'm keeping the receipt just in case the workflow, you know, actually runs. Files Reviewed (1 file)
Reviewed by efficient · Input: 58.2K · Output: 7.6K · Cached: 243.6K |
There was a problem hiding this comment.
🔵 Needs a closer look
Access restrictions prevented verification of the pinned action’s behavior, required permissions, and runner-label support.
No open issues 🎉
What changed in this PR
Replaces standalone workflow linting with centralized PR validation, intended to support the Ubuntu 26.04 runner migration without local actionlint configuration.
Changes:
- Pins
bcgov/actions/pr-validateto the specified v0.9.0 commit. - Adds read-only pull-request permission to the lint job.
| File | Description |
|---|---|
.github/workflows/pr.yml |
Adopts centralized validation and adds its pull-request read permission. |
Review effort: Balanced
The workflow linter in PR CI ran a standalone, unconfigured actionlint container that lacked support for newer GitHub runner labels and required per-repo configuration to resolve.
Replaces
docker://rhysd/actionlint:1.7.12withbcgov/actions/pr-validate@79aefe3a7abb2d0d00b1b3ea4cfbf12727a10638(# v0.9.0) in theactionlintjob, matching the centralized canary standard. Centralizedpr-validatebundles recognition forubuntu-26.04andubuntu-26.04-arm, eliminating the need for local.github/actionlint.yamlconfig sprawl.Refs #789, #790
Summary by CodeRabbit