fix: clear Tutor Quality Stage 1 Sonar debt - #114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This maintenance PR fixes exactly the four pre-existing SonarQube New-Code findings that remained outside Tutor Quality Stage 2A:
scripts/validate-tutor-course-content.mjsserver/services/course-content/tutor-quality-directory-validator.tsserver/services/course-content/tutor-quality-validator.tsThe changes are minimal and behavior-neutral: CLI argument branching/template construction, removal of redundant type assertions, and extraction of named validation helpers without changing validation rules. Targeted regression tests cover the existing CLI usage status and unknown-topic validation behavior.
Boundaries
Verification
All checks were run under Node 24.20.0:
npm run test:tutor-quality: 24 files, 182 tests passednpm run test:unit: 238 files, 2443 tests passed, 1 existing skipnpm run check: passednpm run check:docs: passedgit diff --check: passedThe pre-push hook repeated the unit and coverage/Sonar checks successfully.