refactor: remove obsolete exported dead code - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ten pre-existing Knip diagnostics from the repository instead of
carrying them permanently as accepted baseline debt.
The cleanup removes only unused exports/types and two obsolete deprecated
internal compatibility aliases.
Removed diagnostics
Unused exports:
anchorCourseContentRevisionisTutorPlanningTransitionDockerCompileSemaphoregetDockerCompileSemaphoreUnused exported types:
CourseContentManifestTutorPhaseTutorQualityCasesTopicExtensionThe two duplicate-export diagnostics disappear with the obsolete Sandbox
compatibility aliases.
Compatibility review
The removed symbols have no consumers in repository code, tests or
documentation.
The two Sandbox aliases were marked as deprecated internal compatibility
aliases. No supported public package surface or documented external use was
found.
Used schemas and parser logic remain intact; in particular
courseContentManifestSchemais unchanged.Verification
npx knip— 0 findings, exit 0npm run check— passednpm run check:docs— passednpm run test:tutor-quality— 216 passednpm run test:unit— 2477 passed / 1 skippedgit diff --check— passedbash -n run-tests.sh— passed./run-tests.sh— passedScope
No changes to:
run-tests.sh