Fix hidden-UI false positives on generic View.GONE toggles - #124
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thank you @ajinabraham 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
android_kotlin_hiddenuiandandroid_hidden_uito sensitive-sounding view names (password,pin,token, etc.) so ordinary visibility toggles on dividers, buttons, and snackbars no longer fire as findings.Fixes #123.
Test plan
semgrep --validate --stricton the Kotlin and Java hidden-UI rule filessemgrep --testforandroid.yaml/hidden_ui.yaml(benignheaderDivider/btn2cases areok:, sensitivepasswordView/passwordFieldcases areruleid:)pytest tests(45 passed)Made with Cursor