Skip unparsable XML instead of reusing the previous document - #127
Open
marcelxsilva wants to merge 1 commit into
Open
marcelxsilva wants to merge 1 commit into
marcelxsilva wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an XML file fails to parse,
scan_manifestfalls through with the previous file's document, so the unparsable file is reported with the previous manifest's findings and the output depends on file ordering.The fix skips the file after logging the parse failure. Adds a regression test in
tests/unit/test_xml.pywith a valid manifest followed by an unparsable fragment.Fixes #126.