perf: share vocab-parallel top-k logits for target and draft - #1534
Open
sufubao wants to merge 3 commits into
Open
perf: share vocab-parallel top-k logits for target and draft#1534sufubao wants to merge 3 commits into
sufubao wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the exact vocab-parallel greedy output with a shared top-k candidate path, following the approach in #1512.
logits_logsumexpbookkeeping and the dedicated exact-greedy kernelsGreedy token selection remains exact because every TP shard contributes its local maximum among the candidates. Probabilities returned from sparse logits are intentionally approximate candidate-set probabilities.
Configuration
LIGHTLLM_VOCAB_PARALLEL_TOPK=1: enable the target-model sparse pathLIGHTLLM_VOCAB_PARALLEL_TOPK_SIZE: local candidate count per TP rank, default128Draft models always use the shared top-k path.
Validation
git diff --check: passed