chore(lance): upgrade to 9.0.0-beta.21#349
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The feature-gated failpoint suite passes all 111 tests.
Greptile Summary
This PR upgrades OmniGraph's Lance dependency to 9.0.0-beta.21 and realigns the engine with the new surface. The main changes are:
Confidence Score: 4/5
This is close, but the branch recovery cleanup path should be fixed before merging.
crates/omnigraph/src/branch_control.rs and the branch recovery discard path
Important Files Changed
Comments Outside Diff (1)
crates/omnigraph/src/branch_control.rs, line 55 (link)This normalization now covers the
TableStore::force_delete_branchcleanup paths, but the same already-reclaimed branch case is still reachable from recovery. The no-effect fork discard path calls Lance'sdataset.force_delete_branch(target_branch)directly and maps any Lance error toOmniError::Lance, so a fork that another cleanup already removed can still turnRefNotFoundorNotFoundinto a recovery failure instead of converging as already deleted. Routing that recovery discard through this idempotent helper keeps branch cleanup behavior consistent.Reviews (2): Last reviewed commit: "fix(branches): preserve idempotent NotFo..." | Re-trigger Greptile
Context used: