Repository navigation
Fix Settings scroll jank from section nav and sticky blur - #62
Merged
Merged
Conversation
IntersectionObserver was calling getBoundingClientRect on every scroll callback (layout thrashing). Coalesce updates to rAF, use observer entry geometry only, skip no-op active-id updates, and replace sticky backdrop-filter with solid paints. Long sections use content-visibility to skip off-screen paint. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPageSectionNav now batches section tracking updates, removes layout-forcing measurements, and respects reduced-motion preferences. Styles add section containment, remove backdrop blur, and use solid navigation backgrounds. The changelog records the fix. ChangesScroll performance and section navigation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes scroll lag on Settings (especially near the top) and other long multi-section pages.
Cause
The sticky “On this page” nav’s
IntersectionObservercalledgetBoundingClientRect()on multiple sections on every callback (with many thresholds), forcing layout while scrolling. Sticky chrome also usedbackdrop-filter: blur, which is costly in desktop WebView.Fix
requestAnimationFrame, fewer thresholds, skip no-opsetActiveId.page-sectionblocks:content-visibility: autoso off-screen sections (e.g. Integrations) skip paint until near the viewportTest plan
pnpm --filter @prm/ui typecheckSummary by CodeRabbit