Skip to content

feat: Added a teleport button in the Entity Systems profiler tab #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthonywongskyboxlabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Added a teleport button in the Entity Systems profiler tab #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions webview-ui/src/diagnostics_panel/prefabs/tabs/ClientEntitySystems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ function resolveSystemCategoryGroupKey(fullName: string, systemCategoryLegendMap
const StatsTab: TabPrefab = {
name: 'Client - Entity Systems',
dataSource: TabPrefabDataSource.Client,
content: ({ selectedClient }: TabPrefabParams) => {
content: ({ selectedClient, onRunCommand }: TabPrefabParams) => {
useDebuggerRequestUpdates();
const [lastRequestedCommand, setLastRequestedCommand] = useState<string>('');
const [entityTimingUnit, setEntityTimingUnit] = useState<TimingUnit>('ms');
Expand Down Expand Up @@ -708,6 +708,17 @@ const StatsTab: TabPrefab = {
): JSX.Element => {
const entityId = extractEntityId(row.category);
const optionalStats = entityId ? optionalEntityStatsById.get(entityId) : undefined;
const coordinates = [optionalStats?.positionX, optionalStats?.positionY, optionalStats?.positionZ];
const dimension = optionalStats?.dimension?.trim() ?? '';
const hasValidTeleportDestination =
selectedClient.trim().length > 0 &&
dimension.length > 0 &&
coordinates.every(value => typeof value === 'number' && Number.isFinite(value));

// Teleports the selected client to this entity's dimension and coordinates if they are valid.
const teleportCommand = hasValidTeleportDestination
? `/execute in ${dimension} run tp ${JSON.stringify(selectedClient)} ${coordinates.join(' ')}`
: undefined;

return (
<div className="minecraft-entity-row-details">
Expand Down Expand Up @@ -737,6 +748,18 @@ const StatsTab: TabPrefab = {
</span>
</div>
</div>
<VSCodeButton
style={{ alignSelf: 'flex-start' }}
disabled={!teleportCommand}
title={teleportCommand ? undefined : 'Player name, entity dimension, or position is unavailable'}
onClick={() => {
if (teleportCommand) {
onRunCommand(teleportCommand);
}
}}
>
Teleport to Entity
</VSCodeButton>
<div className="minecraft-entity-row-details-chart">
<div className="minecraft-entity-row-details-chart-title">
Trend ({formatSparklineDurationFromPoints(context.sparklineTickRange)})
Expand All @@ -757,7 +780,7 @@ const StatsTab: TabPrefab = {
</div>
);
},
[entityTimingUnit, optionalEntityStatsById],
[entityTimingUnit, optionalEntityStatsById, selectedClient, onRunCommand],
);

return (
Expand Down
Loading