Skip to content

feat: add achievements plugin friends feature #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadicalMuffinMan merged 4 commits into from
Sep 30, 2026
Merged

feat: add achievements plugin friends feature #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0369ef
feat(settings): add friends button
bientavu Sep 29, 2026
6dbd893
Merge remote-tracking branch 'Moonfin-Client/master' into feat/add-ac…
bientavu Sep 29, 2026
6e98f64
refactor(settings): remove mute chat banners during playback option
bientavu Sep 29, 2026
dc5822d
updated #304 to add showFriendsButton to the Emby profile model so bo…
RadicalMuffinMan Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Emby/Emby.Plugins.Moonfin/Models/MoonfinSettingsProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ public class MoonfinSettingsProfile
[JsonPropertyName("showLiveTvButton")] public bool? ShowLiveTvButton { get; set; }
[JsonPropertyName("showDownloadsButton")] public bool? ShowDownloadsButton { get; set; }
[JsonPropertyName("showServerMessagesButton")] public bool? ShowServerMessagesButton { get; set; }
[JsonPropertyName("showFriendsButton")] public bool? ShowFriendsButton { get; set; }
[JsonPropertyName("crashReportsEnabled")] public bool? CrashReportsEnabled { get; set; }
[JsonPropertyName("diagnosticLoggingEnabled")] public bool? DiagnosticLoggingEnabled { get; set; }
[JsonPropertyName("updateNotificationsEnabled")] public bool? UpdateNotificationsEnabled { get; set; }
Expand Down
7 changes: 7 additions & 0 deletions Jellyfin/backend/Models/MoonfinSettingsProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,13 @@ public class MoonfinSettingsProfile
[JsonPropertyName("showServerMessagesButton")]
public bool? ShowServerMessagesButton { get; set; }

/// <summary>
/// Friends button for the Achievement Badges plugin. Clients only show it
/// when that plugin has friends turned on.
/// </summary>
[JsonPropertyName("showFriendsButton")]
public bool? ShowFriendsButton { get; set; }

[JsonPropertyName("diagnosticLoggingEnabled")]
public bool? DiagnosticLoggingEnabled { get; set; }

Expand Down
11 changes: 11 additions & 0 deletions Jellyfin/backend/Pages/configPage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,15 @@ <h4 style="margin: 1.5em 0 0.5em; font-size: 0.95em; color: #00a4dc;">Nav Button
<option value="false">No</option>
</select>
</div>
<div class="inputContainer">
<label class="inputLabel inputLabelUnfocused" for="DefaultShowFriendsButton">Show Friends Button</label>
<select id="DefaultShowFriendsButton" is="emby-select">
<option value="">Not set (user decides)</option>
<option value="true">Yes</option>
<option value="false">No</option>
</select>
<div class="fieldDescription">Only shows where the Achievement Badges plugin has friends turned on.</div>
</div>
</div>

<!-- 4. Home Screen -->
Expand Down Expand Up @@ -6125,6 +6134,7 @@ <h3 class="sectionTitle">Active Downloads</h3>
setNullableBoolSelect('#DefaultShowLiveTvButton', defaults.showLiveTvButton);
setNullableBoolSelect('#DefaultShowDownloadsButton', defaults.showDownloadsButton);
setNullableBoolSelect('#DefaultShowServerMessagesButton', defaults.showServerMessagesButton);
setNullableBoolSelect('#DefaultShowFriendsButton', defaults.showFriendsButton);

setSelectValue('#DefaultMediaBarSourceType', defaults.mediaBarSourceType, 'Configured source');
loadAdminGenrePicker(defaults.mediaBarExcludedGenres || []);
Expand Down Expand Up @@ -6928,6 +6938,7 @@ <h3 class="sectionTitle">Active Downloads</h3>
config.DefaultUserSettings.showLiveTvButton = getNullableBoolSelect('#DefaultShowLiveTvButton');
config.DefaultUserSettings.showDownloadsButton = getNullableBoolSelect('#DefaultShowDownloadsButton');
config.DefaultUserSettings.showServerMessagesButton = getNullableBoolSelect('#DefaultShowServerMessagesButton');
config.DefaultUserSettings.showFriendsButton = getNullableBoolSelect('#DefaultShowFriendsButton');

config.DefaultUserSettings.mediaBarSourceType = document.querySelector('#DefaultMediaBarSourceType').value || null;
var genreIds = [];
Expand Down
Loading