fix(kimi-code): guard footer PR lookup spawn failures#89
Open
caigee-cmd wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 282a87a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #87
Problem
A fresh install could crash on startup before the TUI finished rendering. The footer does a best-effort
gh pr viewlookup, and in the reported environment that spawn path failed withENOTDIR. Because the failure was thrown synchronously, it escaped the normal callback error handling and took down the process.What changed
Wrapped the
gh pr viewspawn inreadPullRequest()with a localtry/catchso spawn-time failures degrade tonullinstead of crashing the app.Also added a regression test that mocks a synchronous
spawn ENOTDIRthrow and verifies the footer git status still renders normally.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.