Render html frame diagrams#15
Closed
gerchowl wants to merge 4 commits into
Closed
Conversation
Co-authored-by: lars.gerchow <lars.gerchow@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: lars.gerchow <lars.gerchow@gmail.com>
Co-authored-by: lars.gerchow <lars.gerchow@gmail.com>
Co-authored-by: lars.gerchow <lars.gerchow@gmail.com>
Contributor
Author
|
does not work p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement HTML Frame-Based Diagram Rendering to simplify the workflow and enable dynamic theme switching for diagrams in HTML output.
The previous approach required pre-compiling diagrams into separate light/dark SVG files and then injecting them into the HTML, leading to a complex build pipeline and larger file sizes. This new approach leverages Typst's
html.frameto generate inline SVGs directly during HTML compilation, with a JavaScript module handling dynamic recoloring based on the active theme. This results in a simpler, more efficient, and more maintainable system.