Skip to content

ums: record forgetting to undraft review-ready PRs - #2346

Merged
d-morrison merged 9 commits into
mainfrom
ums-draft-prs
Aug 27, 2026
Merged

ums: record forgetting to undraft review-ready PRs#2346
d-morrison merged 9 commits into
mainfrom
ums-draft-prs

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

UMS pass after feedback about PR 2295.

What Where Change
Forgetting to undraft memories/mistake-patterns.md Added Pattern 13

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@d-morrison

Copy link
Copy Markdown
Collaborator Author

Working on this --- please hold off on pushing to this branch until I'm done.

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


No em-dashes or curly quotes — compliant with shared/coding/ascii-punctuation-in-source.md. Content, citations, and formatting all check out. No new findings.

Given this is a documentation-only, low-risk PR (two memory pattern entries following the file's established format) whose content has been reviewed and found clean across three prior rounds (identical content at heads 61d2855b, 2edc74bf, and now f2cfbe0709), and I've independently re-verified both canonical-rule quotes are verbatim-accurate against AGENTS.md, I have no new findings to report.

Verdict

Ready for merge. The diff content is unchanged from the previously-reviewed and approved commits (see prior rounds at 61d2855b and 2edc74bf), and I independently re-verified both canonical-rule quotes in the new Pattern 13/14 entries against AGENTS.md (lines 302–336 and line 33) — both are verbatim-accurate. No ASCII-punctuation violations, no duplicate/overlapping content with existing Pattern 5g (the diff itself correctly scopes Pattern 14 as the general case, Pattern 5g as the PR-monitoring special case), and the structure matches the file's established Mistake/Example/Canonical Rule/Fix convention. Referenced issue ai-config#2295 exists and is merged, consistent with the claim. No blocking or non-blocking findings.

Reviewed commit: f2cfbe0

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $1.0717 (review) — run

@d-morrison
d-morrison merged commit 56862d1 into main Aug 27, 2026
10 checks passed
@d-morrison
d-morrison deleted the ums-draft-prs branch August 27, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant