ci(docker): trim the manual-rebuild comment — functional reason only - #149
Merged
Merged
Conversation
The comment above `workflow_dispatch:` narrated operational history of the hosted deployment. That belongs with the deployment's private runbooks, not in the public workflow (scope rule: no ops content in this repository). It now says only what a manual run does: dispatched on main, it runs the whole chain (build, push, sign, notify-ops, deploy) without a code change. "Dispatched on main" is spelled out because the Run workflow button accepts any ref, and the run the comment describes is the one on main. Comment-only: yaml.safe_load of the file is unchanged, and triggers, jobs, permissions and action pins are byte-identical. The file stays LF (i/lf), so the diff is exactly the comment block. No CHANGELOG entry, in line with earlier CI-only edits that change nothing a user or self-hoster sees. History is not rewritten: nothing in the removed text was secret. Full suite 1250 passed, 64 skipped locally on Windows (incl. test_line_endings); ruff check + format clean; gitleaks and the pre-commit scope patterns clean; security-auditor PASS, code-reviewer APPROVE. i18n drift and pip-audit not applicable: no templates, catalogs or requirements touched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shortens the comment above
workflow_dispatch:in.github/workflows/docker.ymlfrom 10 lines to 3. It now states only what a manual run does:Why
The old comment narrated operational history of the hosted deployment. The project's scope rule keeps ops content out of this public repository, so that history belongs with the deployment's private runbooks. "Dispatched on main" is spelled out because the Run workflow button accepts any ref.
Scope
yaml.safe_loadof the file is unchanged. Triggers, jobs, permissions and action pins are byte-identical.git ls-files --eolshowsi/lf), so the diff is exactly the comment block (+2/−9). This builds on fix(ci): renormalize docker.yml to LF — and fail CI on CRLF blobs #141, which renormalised the file to LF.uses:lines, not the comment, so there is no textual overlap.Verification
test_line_endings.scripts/scope_review.pyreports no concerns.🤖 Generated with Claude Code