Repository navigation
fix: make downloadable installer workflow runnable and test it in Docker - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downloadable installer workflow used shell: bash, which the Action rejects (valid modes are auto, shebang and posix), and named its report .json while saving the default table format. Select auto and explicitly request JSON.
Tests read the maintained workflow directly: validate all copied inputs through the CLI, then execute its generated installer wrapper in the four-image matrix for a working installed binary and an installer that prints success and exits zero without installing. Assert the expected program output, failure reason and parseable JSON report for every image. This caught both the rejected shell input and mislabeled report. PyYAML is added only to the test extra.
Local validation: 203 passed, 1 skipped (non-integration). Docker validation runs in the existing integration CI job.