Use heatsource based on varying supply temperature - #481
Open
tolga-akan wants to merge 7 commits into
Open
Conversation
tolga-akan
marked this pull request as ready for review
May 29, 2026 13:38
tolga-akan
requested review from
FJanssen-TNO,
KobusVanRooyen and
jimrojerTNO
as code owners
May 29, 2026 13:38
Collaborator
Author
|
@KobusVanRooyen Ready to review. Currently I created the temperature_regimes list inside the problem class by using the carrier names. This list includes the temperatures of <base_carrier_name>_. Shall we define the list of temperature regimes in esdl_parser? Do you think the current way of defining of the list is enough for the time being. |
Collaborator
|
@tolga-akan review completed |
…_supply_temp # Conflicts: # CHANGELOG.md
Collaborator
Author
|
@KobusVanRooyen ready for reviewing |
| f"{sup_carrier}_{supply_temperature}" | ||
| ) | ||
|
|
||
| heat_out_expected = discharge * cp * rho * supply_temperature |
Collaborator
There was a problem hiding this comment.
You will have to revert this code if you want to use the new code from main here
|
|
||
| ## Added | ||
| - ESDL profile reading and writing for different types: influxdb and postgres, and inline (in ESDL file). | ||
| - A heat source asset is eligible for use only when its maximum temperature |
Collaborator
There was a problem hiding this comment.
This will have to be removed. Since this PR will only be adding a test case, for which we do not add in the CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use heatsource if asset max temperature is larger than or equal to network supply temperature for the case with network supply temperature has multiple temperature options: