Skip to content

Implement Job Metrics and its APIs#4

Open
Bmete7 wants to merge 11 commits into
developfrom
tvb-bm/feat/circuit_metrics_table
Open

Implement Job Metrics and its APIs#4
Bmete7 wants to merge 11 commits into
developfrom
tvb-bm/feat/circuit_metrics_table

Conversation

@Bmete7

@Bmete7 Bmete7 commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Fixes #2, #3

Creates a new table called TimestampData, which currently holds 14 different job metrics, as entry and finish times as timestamps.

The PR further includes INSERT and SELECT methods, to be called by the respective repositories.

@Bmete7 Bmete7 requested a review from mnfarooqi November 24, 2025 16:31
@Bmete7 Bmete7 changed the title Tvb bm/feat/circuit metrics table Implement Job Metrics and its APIs Nov 24, 2025

@mnfarooqi mnfarooqi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added inline comments.

Comment thread bqp_database_access/_database.py
Comment thread bqp_database_access/job_metrics.py Outdated
@mdepasca-mqv

Copy link
Copy Markdown
Collaborator

@Bmete7 is this PR still valid?

@Bmete7

Bmete7 commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

@mdepasca-mqv Yes, we were waiting for other repositories to be updated before we merge this. Now there seems to be a conflict though- I will work on it next week and then we can merge.

@kalliope192 kalliope192 force-pushed the tvb-bm/feat/circuit_metrics_table branch from 955cb92 to 9f475e0 Compare May 18, 2026 10:06
Copilot AI review requested due to automatic review settings May 18, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@kalliope192

Copy link
Copy Markdown
Collaborator

I've rebased and tested that these changes don't break dashboard-backend but deployment of bqp-api fails for me and I can't access qjr so these two items remain to be tested.

@Bmete7 I've also added the timestamp_data table on staging including CRUD-rights for users api, dashboard and qjr.

@shankantana shankantana force-pushed the tvb-bm/feat/circuit_metrics_table branch from 9f475e0 to beba8a9 Compare June 22, 2026 12:27
@shankantana shankantana force-pushed the tvb-bm/feat/circuit_metrics_table branch from beba8a9 to a24411a Compare June 22, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CircuitMetrics table with foreign key to circuit job entries

5 participants