chore: pin shared ci refs and run pre-push validation stage#77
Open
N4M3Z wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
quality.yamlandrelease.yamlreferencesetup-forgeandmodule-release.yamlat@main, so any push to forge-cli changes CI behavior for every module and no run is reproducible. CI also runs only the commit-stage prek hooks, so pre-push-stage gates never execute here (forge-text already runs both stages). Superseded runs on the same ref keep executing to completion.Fix
Pin both forge-cli refs to
v0.3.2(identical content to main today, verified by diff). Run the pre-push prek stage after the commit stage so CI matchesmake validate. Add a concurrency group that cancels superseded runs.Test plan
module-release.yamlandsetup-forge/action.ymldiffed empty betweenv0.3.2andorigin/main