feat: add PullRequest skill owning the PR lifecycle#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PullRequestskill (skills/PullRequest/SKILL.md): owns the PR lifecycle the always-on PullRequests rule only described. Preflight + duplicate discovery, body to the house standard, create viagh/glab, feedback retrieval, CI gate, squash-merge + branch cleanup, and the stacked-PR retargeting trap. Hands off to ReceiveReview (feedback rigor), FixCI (red checks), FinishBranch (merge vs PR vs discard).RequestReview(skills/RequestReview/SKILL.md): drops theopening a PRtrigger that collided with the new skill, cross-links the two so "open a PR" routes here and "ask for a review" routes there.Fixes folded in along the way: a fabricated
glab mr create --description-fileflag (glab has no file-reading description flag, use--description "$(cat body)"), a missing CI gate, the RequestReview routing overlap.Test plan
forge validate --source .passes (skill structure, frontmatter, heading depth)RequestReviewdescription no longer claimsopening a PR; the two skills cross-linkmake install+/reload-skillsto deploy