refactor: retire FinishBranch, absorbed by ExecutePlan#18
Open
N4M3Z wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FinishBranch was a git-only adopted skill (branch + worktree finishing) that contradicted the jj routing: in jj-colocated repos there are no branches to finish and no worktrees to remove. Its Integration section referenced upstream skill names that do not exist here, and nothing invoked it by name.
Fix
Delete the skill. Its finishing flow (merge / PR / keep / discard, cleanup) lives in forge-core ExecutePlan as the Finish step, with mechanics for both git and jj (see N4M3Z/forge-core#67).
Test plan
qualitypasses on this PR