Fix EXT_structural_metadata property tables when buffer views use EXT_meshopt_compression - #1676
Merged
gkjohnson merged 1 commit intoAug 7, 2026
Conversation
Contributor
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1675.
getRelevantBuffers()loaded property-table buffer views withparser.loadBufferView( index ), which bypasses the GLTF loader plugin hooks — so buffer views compressed withEXT_meshopt_compressionwere never decompressed and property values silently decoded as empty/no-data. Going throughparser.getDependency( 'bufferView', index )runs the hooks, the same way three's own extensions load buffer views.Verified against the PDOK 3D Tiles from the issue: property values (strings and numerics) now decode correctly, and behavior for uncompressed files is unchanged.