feat: AddTempLayer plugin (WMS/WMTS/XYZ/GeoJSON) + core layer-add bus by BhattaraiSijan · Pull Request #126 · NASA-IMPACT/MMGIS

BhattaraiSijan · 2026-06-09T19:28:27Z

Purpose

Add an AddTempLayer plugin — "Add layer from URL" — letting users drop an external WMS / WMTS / XYZ / GeoJSON layer onto the map for the current session, plus the core event-bus and rendering support it needs. Built to the monorepo tool pattern: a portable lib/ of presentational React components with all MMGIS coupling isolated in adapters/, communicating with the core over the window.mmgisAPI event bus only.

Note on discoverability

The plugin shipping without its own trigger button is intentional, not an
oversight. AddTempLayer follows the framework's decoupled-plugin model: it
exposes a bus contract and leaves when and from where it opens to the app
builder.

Public contract: emitting addTempLayer:show on the MMGIS bus
(window.mmgisAPI.emit('addTempLayer:show')) opens the form. Any plugin,
toolbar button, or host-app code can be the trigger — the plugin does not
care who emits it.

Proposed Changes

[ADD] AddTempLayer plugin (monorepo pattern):
- lib/ (portable): AddTempLayerPanel (trigger + form state) and AddLayerModal (presentational), utils/url (validateUrl, detectLayerType), utils/icons, BEM blocks-* classes, Path A --theme-* styling.
- adapters/buildLayerObj (URL → MMGIS layer object), MMGISAddTempLayerAdapter (bus bridge), thin AddTempLayerTool (createRoot), config.json with modern-layout metadata.
[ADD] Core bus channels layers:addLayer / layers:removeLayer (Layers_.js), backed by mmgisAPI.addLayer/removeLayer — session-only, in-memory add via resetConfig + modifyLayer (lost on reload).
[ADD] WMS / WMTS rendering support:
- DeckGL: WMSLayer branch in DeckGLHelpers (with parseWmsUrl) selected when tileformat === 'wms'; tileformat threaded through TileLayerOptions and the deck tile call in Map_.js.
- Leaflet: WMS already supported via WMSColorFilter.
- WMTS-KVP is rewritten plugin-side into a {z}/{y}/{x} template so it renders through the standard template-tile path in both engines.
[CHANGE] layers:listChanged event replaces the direct LayersTool destroy/make on layer mutation, so any subscriber (modern or classic layout) can react — decoupled.
[CHANGE] validateUrl rejects internal whitespace, guarding against two URLs pasted into one field.

Issues

Add external service layer plugin

Testing

npm run typecheck → 0 errors.

Browser (DeckGL engine), verified end-to-end per type — add one URL at a time:

XYZ

https://tile.openstreetmap.org/{z}/{x}/{y}.png

WMS (needs a LAYERS param)

https://ows.terrestris.de/osm/service?SERVICE=WMS&REQUEST=GetMap&LAYERS=OSM-WMS

WMTS — REST template

https://gibs.earthdata.nasa.gov/wmts/epsg3857/best/BlueMarble_ShadedRelief/default/GoogleMapsCompatible_Level8/{z}/{y}/{x}.jpeg

WMTS — KVP (exercises the KVP→template rewrite)

https://gibs.earthdata.nasa.gov/wmts/epsg3857/best/wmts.cgi?SERVICE=WMTS&REQUEST=GetTile&VERSION=1.0.0&LAYER=BlueMarble_ShadedRelief&STYLE=default&TILEMATRIXSET=GoogleMapsCompatible_Level8&FORMAT=image/jpeg

GeoJSON (CORS-enabled host)

https://raw.githubusercontent.com/PublicaMundi/MappingAPI/master/data/geojson/countries.geojson

…to feat/add-temp-layer-plugin

github-actions · 2026-06-17T18:26:34Z

✅ Version Already Updated

This PR includes a manual version update to 4.2.21-20260723

No automatic version bump needed.

BhattaraiSijan · 2026-06-23T20:16:07Z

Update — URL handling reworked (`b8e735cd`, `292931f3`)

The plugin is now a pure pass-through — it no longer constructs, rewrites, or substitutes anything in the URL. This supersedes the
"WMTS-KVP rewritten into a {z}/{y}/{x} template" point above.

Removed buildWmtsTemplate and the {s} substitution; wms/wmts/xyz URLs are passed through verbatim.
Two-stage handling in utils/url: detectLayerType (GeoJSON/WMS/WMTS/XYZ, else unsupported) → new validateForType
structural check (WMS needs LAYERS; XYZ/WMTS need {z}/{x}/{y}; GeoJSON none), with a per-type example URL in the error message.
Panel wired to that pipeline; modal help text reworded and error text wraps.
Added tests/unit/addTempLayerUrl.spec.js covering detection, validation, and verbatim build (npm run test:unit).

…to feat/add-temp-layer-plugin

…ombie resurrection, hung promise)

github-actions · 2026-07-21T20:09:24Z

🤖 Version Auto-Bumped

The version has been automatically incremented to 4.2.21-20260723

This commit was added to your PR branch. When you merge this PR, the new version will be included.

_{If you want a different version, update package.json manually and push to this PR.}

The plugin is now only the 'Add layer from URL' form, living hidden in a float-top-right panel. Any plugin reveals it by emitting 'addTempLayer:show'; the close button hides it again. The dotted trigger button is gone — it belongs to whichever host wants to offer it (e.g. LayerManager). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

parseWmsUrl previously kept only LAYERS

BhattaraiSijan · 2026-07-22T18:00:11Z

Summary of fixes

The layer panel in the classic layout stopped refreshing when layers were added or removed at runtime. Restored the direct panel rebuild so it always shows the current layer list.
The local development CORS proxy was accidentally disabled by a leftover flag that could never be turned on. Removed the flag so the proxy works automatically in development again.
Pasted WMS URLs lost their extra settings (image format, transparency, styles, API keys) in the 3D-capable engine, so layers could render differently than in 2D. These settings are now passed along with every request.
Tile URLs with an {s} placeholder were accepted but then silently rendered nothing. The form now rejects them and asks the user to use a real subdomain instead.
The WMS rendering path relies on a third-party component marked experimental. Added a code note so future upgrades know to re-verify it.

slesaad · 2026-06-17T19:33:04Z

-        if (ToolController_.activeToolName === 'LayersTool') {
-            const layersTool = ToolController_.getTool('LayersTool')
-            if (layersTool.destroy && layersTool.make) {
-                layersTool.destroy()
-                layersTool.make()
-            }


why did we need to remove this?

restored it in 036b554

slesaad · 2026-07-22T20:37:18Z

+    const u = (url || '').trim().toLowerCase()
+    if (u.length === 0) return null


is there a reason this has to be repeated here? you're calling validateUrl already before passing it to detectLayerType. So you could assume that url has been validated on the latter

slesaad · 2026-07-22T21:26:33Z

+    if (u.includes('service=wmts') || u.includes('request=gettile')) {
+        return 'wmts'
+    }
+
+    // WMS — OGC KVP markers
+    if (u.includes('service=wms') || u.includes('request=getmap')) {
+        return 'wms'
+    }


i wonder if these should be and instead of or

slesaad · 2026-07-22T21:28:00Z

+    type: TempLayerType,
+    url: string,
+): ValidationResult {
+    const u = (url || '').trim().toLowerCase()


same comment as above. redundant

slesaad · 2026-07-22T21:29:39Z

+    // {s} is Leaflet's pick-a-subdomain placeholder. We never substitute it,
+    // and the deck.gl engine sends it to the network literally — every request
+    // fails after an apparently successful add. Make the user pick one.
+    if (u.includes('{s}')) {
+        return {
+            ok: false,
+            message: `We can’t add this layer — {s} is a subdomain placeholder we don’t fill in. Replace it with a real subdomain, e.g. https://a.tile.host/{z}/{x}/{y}.png`,
+        }
+    }


not sure why this is needed

slesaad · 2026-07-22T21:31:40Z

+    if (!(u.includes('{z}') && u.includes('{x}') && u.includes('{y}'))) {
+        const kind = type === 'wmts' ? 'WMTS' : 'XYZ'
+        return {
+            ok: false,
+            message: `We can’t add this layer — the ${kind} URL needs a {z}/{x}/{y} template. Example: ${SAMPLE_URLS[type]}`,
+        }
+    }


wmts doesnt require {z}/{x}/{y}

slesaad · 2026-07-22T21:34:24Z

+        // Notify subscribers (e.g. the modern-layout Layers panel) that the
+        // layer list changed, so they rebuild.
+        if (window.mmgisAPI) {
+            window.mmgisAPI.emit('layers:listChanged')
+        }


probably redundant

…IMPACT/MMGIS into feat/add-temp-layer-plugin

BhattaraiSijan added 8 commits June 8, 2026 11:34

scaffold new tool

bf05c02

addtemp layer wip

cd09523

Merge branch 'development' into feat/add-temp-layer-plugin

95fee30

Merge branch 'development' of https://github.com/NASA-IMPACT/MMGIS in…

d71bce6

…to feat/add-temp-layer-plugin

refractor to monorepo pattern

631b855

wms support

6480f2b

build url for wms

a2fb143

clean up

ea24af2

BhattaraiSijan requested review from sandesh-sp and slesaad June 9, 2026 19:28

refractor remove buildwmtstemplate and add validation

b8e735c

add sample urls in validation error message

292931f

slesaad linked an issue Jul 15, 2026 that may be closed by this pull request

Add external service layer plugin #102

Open

BhattaraiSijan and others added 3 commits July 20, 2026 13:43

Merge branch 'development' of https://github.com/NASA-IMPACT/MMGIS in…

e2da0a1

…to feat/add-temp-layer-plugin

Fix addLayer/removeLayer config corruption (duplicate fall-through, z…

8996d46

…ombie resurrection, hung promise)

chore: bump version to 4.2.19-20260721 [version bump]

a2c5967

BhattaraiSijan requested a review from CarsonDavis July 21, 2026 20:09

BhattaraiSijan and others added 7 commits July 21, 2026 16:34

Restore classic-layout LayersTool rebuild in modifyLayer

036b554

Remove leftover ENABLE_CORS_PROXY gate on dev corsproxy

ddf1a95

Forward pasted WMS GetMap params in the deck.gl engine

b7c27b5

parseWmsUrl previously kept only LAYERS

Reject {s} subdomain placeholder in temp-layer URL validation

d1e3f6f

Document experimental status of deck.gl's _WMSLayer

74e6a73

chore: bump version to 4.2.20-20260722 [version bump]

e03c5e4

slesaad reviewed Jul 22, 2026

View reviewed changes

Drop redundant guards in detectLayerType/validateForType

269a2ce

BhattaraiSijan and others added 6 commits July 23, 2026 09:43

Merge branch 'feat/add-temp-layer-plugin' of https://github.com/NASA-…

b815d9e

…IMPACT/MMGIS into feat/add-temp-layer-plugin

chore: bump version to 4.2.21-20260723 [version bump]

71701b2

Add engine-reported layer load status to core

086724f

AddTempLayer: add optimistically, surface the engine's verdict

1bfb82c

Make layer loadStatus per-layer, not per-request

3528e0a

Merge branch 'feat/add-temp-layer-plugin' of https://github.com/NASA-…

6c4348d

…IMPACT/MMGIS into feat/add-temp-layer-plugin

		const u = (url \|\| '').trim().toLowerCase()
		if (u.length === 0) return null

Uh oh!

Conversation

BhattaraiSijan commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Note on discoverability

Proposed Changes

Issues

Testing

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Version Already Updated

Uh oh!

BhattaraiSijan commented Jun 23, 2026

Update — URL handling reworked (b8e735cd, 292931f3)

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Version Auto-Bumped

Uh oh!

BhattaraiSijan commented Jul 22, 2026

Summary of fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BhattaraiSijan commented Jun 9, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

Update — URL handling reworked (`b8e735cd`, `292931f3`)

github-actions Bot commented Jul 21, 2026 •

edited

Loading