Skip to content

[233] Untrack generated configure/public/toolConfigs.json - #234

Merged
CarsonDavis merged 1 commit into
developmentfrom
feature/233-untrack-toolconfigs
Jul 29, 2026
Merged

[233] Untrack generated configure/public/toolConfigs.json#234
CarsonDavis merged 1 commit into
developmentfrom
feature/233-untrack-toolconfigs

Conversation

@CarsonDavis

@CarsonDavis CarsonDavis commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Closes #233

configure/public/toolConfigs.json is listed in .gitignore (line 17), but the rule has never applied: the configure-beta rewrite (NASA-AMMOS#574, 2024) moved the generated manifest to this path while the gitignore still pointed at the old /config/pre/toolConfigs.json location, so the file was committed unignored. When the cleanup in NASA-AMMOS#831 (2025) fixed the gitignore path, the file was already tracked — and git ignores ignore-rules for tracked files. Every server start and build regenerates it via updateTools(), so feature branches kept accidentally committing generated churn (e.g. 4708dc68, 8737cb4a).

This PR drops the file from the index (git rm --cached) with no code changes. The existing gitignore rule takes over, matching how its sibling componentConfigs.json (same generator, .gitignore:18) is already handled.

Why nothing breaks:

  • Regenerated on every server start (scripts/server.js:699) and every build (scripts/build.js:57), before anything reads it
  • Consumed only at runtime — the Configure app fetches it over HTTP, served by express.static from the source directory; no build-time import exists
  • Docker runs npm run build (which regenerates it) before the Configure build, so a clean context is safe
  • Unit tests mock the tool configs; no CI workflow references the file

Note for teammates: pulling this deletes your local copy of the file. It regenerates on your next npm start or npm run build.

@CarsonDavis CarsonDavis linked an issue Jul 29, 2026 that may be closed by this pull request
4 tasks
@CarsonDavis
CarsonDavis merged commit ab7a99e into development Jul 29, 2026
6 checks passed
@CarsonDavis
CarsonDavis deleted the feature/233-untrack-toolconfigs branch July 29, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untrack the generated tool manifest so its gitignore rule actually applies

2 participants