[233] Untrack generated configure/public/toolConfigs.json - #234
Merged
Conversation
4 tasks
sandesh-sp
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233
configure/public/toolConfigs.jsonis listed in.gitignore(line 17), but the rule has never applied: the configure-beta rewrite (NASA-AMMOS#574, 2024) moved the generated manifest to this path while the gitignore still pointed at the old/config/pre/toolConfigs.jsonlocation, so the file was committed unignored. When the cleanup in NASA-AMMOS#831 (2025) fixed the gitignore path, the file was already tracked — and git ignores ignore-rules for tracked files. Every server start and build regenerates it viaupdateTools(), so feature branches kept accidentally committing generated churn (e.g.4708dc68,8737cb4a).This PR drops the file from the index (
git rm --cached) with no code changes. The existing gitignore rule takes over, matching how its siblingcomponentConfigs.json(same generator,.gitignore:18) is already handled.Why nothing breaks:
scripts/server.js:699) and every build (scripts/build.js:57), before anything reads itexpress.staticfrom the source directory; no build-time import existsnpm run build(which regenerates it) before the Configure build, so a clean context is safeNote for teammates: pulling this deletes your local copy of the file. It regenerates on your next
npm startornpm run build.