Repository navigation
fix(viewer): honor persisted quality and stabilize framing validation - #124
Merged
Merged
Conversation
rldyourmnd
changed the title
rldyourmnd
changed the base branch from
fix/persisted-viewer-resolution-20261007
to
main
October 7, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A persisted viewer.json resolution was applied and then overwritten by the native picker, because startup checked only whether the command line supplied a profile. Respect the configured profile before opening native UI; CLI choices still override the file and unconfigured native launches retain their chooser.
The original macOS run in #123 also exposed a five-second timeout in the maximum-body HTTP framing fixture. Keep seven-byte reads and complete 256 KiB binary equality in both directions, while using a bounded 4 KiB transport buffer to avoid tens of thousands of unnecessary producer/consumer wakeups. Production HTTP limits, timeouts and wire behavior are unchanged.
Validation: the old picker condition fails the intended regression; all three profile/precedence/headless tests pass, strict CLI desktop Clippy passes, and all 11 HTTP framing tests plus strict discovery Clippy pass locally. The original macOS CI failure is retained. Full macOS/Linux CI is pending. This carries two separately signed atomic fixes and supersedes #123 once qualified.