Repository navigation
test(sync): own temporary roots through asynchronous fixture lifetime - #127
Merged
Merged
Conversation
rldyourmnd
marked this pull request as ready for review
October 7, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated v1 and negotiated-sync integration runs left their synthetic file roots behind because the helper returned a bare PathBuf. Give the exact newly created root a shared test-only owner, retain it across serving futures and remove it when its last owner exits. No production sync/data cleanup or name-based sweep is added.
Validation: both complete affected macOS fixture suites pass (24tests including last-owner/symlink regression, cancellation, resume, corruption and impairment). Current strict Clippy/CI qualification remains required. This branch is separate from the frozen GDS consumer transaction and will not enter main until that transaction completes.