Repository navigation
perf(desktop): hash payload receipts during transport IO - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux desktop agent spent ~23.6% of sampled CPU cycles in BLAKE3 hashing while payload receipts were enabled. The sender hashed every encoded frame before writing it, and the receiver hashed the complete body again after reading it.
This change keeps the proof semantics identical while hashing incrementally: the sender updates BLAKE3 from bytes accepted by the async writer, and the receiver updates it as chunks arrive. A receipt cannot be confirmed before the sender has finalized its digest, and transport-only evidence remains distinct.
Validation: cargo fmt, rds-desktop receipt/session tests, targeted clippy. Baseline profile is retained privately; post-merge Linux profile will compare the same workload.