Skip to content

main-dev 동기화#54

Merged
l2juhan merged 3 commits into
developfrom
main
Dec 20, 2025
Merged

main-dev 동기화#54
l2juhan merged 3 commits into
developfrom
main

Conversation

@l2juhan
Copy link
Copy Markdown
Contributor

@l2juhan l2juhan commented Dec 20, 2025

Summary by CodeRabbit

릴리스 노트

  • 버그 수정

    • 상품 카드의 가격 표시 로직을 개선했습니다.
    • 추천 탭에서 판매자 정보 표시를 개선했습니다.
  • 기타

    • API 요청 처리 개선

✏️ Tip: You can customize this high-level summary in your review settings.

@l2juhan l2juhan self-assigned this Dec 20, 2025
@l2juhan l2juhan added the enhancement New feature or request label Dec 20, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

API 요청에 ngrok 브라우저 경고 스킵 헤더를 추가하고, 상품 카드의 가격 렌더링 로직과 추천 탭의 판매자 이름 매핑 방식을 간소화했습니다.

Changes

Cohort / File(s) Summary
API 설정
src/api/common.js
authorizedFetch 함수의 헤더에 'ngrok-skip-browser-warning': 'true' 추가
UI 컴포넌트 로직 간소화
src/pages/MainPage/components/ProductCard.jsx
className 조건부 처리를 인라인으로 개편하고, hidePrice 조건에서 원가 표시 제거, 할인가 렌더링 조건 단순화
판매자 정보 표시
src/pages/MainPage/components/RecommendTab.jsx
sellerName 매핑을 seller_nickname 직접 사용으로 변경 (조건부 seller_id 포맷팅 제거)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • src/api/common.js: 헤더 추가의 의도와 ngrok 환경에서의 영향 범위 확인
  • src/pages/MainPage/components/ProductCard.jsx: 할인가 렌더링 조건 변경이 모든 가격 표시 시나리오를 올바르게 처리하는지 검증
  • src/pages/MainPage/components/RecommendTab.jsx: seller_nickname 필드의 존재 여부와 폴백 동작 확인

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 4b43e48 and 70d6215.

📒 Files selected for processing (3)
  • src/api/common.js (1 hunks)
  • src/pages/MainPage/components/ProductCard.jsx (2 hunks)
  • src/pages/MainPage/components/RecommendTab.jsx (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@l2juhan l2juhan merged commit be79f87 into develop Dec 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant