Add coarse-grained tags to the icinga2 role - #487
Open
Saeid-Abadi wants to merge 3 commits into
Open
Conversation
Expose icinga2_install, icinga2_configure and icinga2_service tags on the top-level includes so playbooks can re-run individual phases without rolling out the full role. Fact gathering and OS-specific variable loading are marked as always so the tagged runs still have the required context.
Introduce a Tags section in the icinga2 role README describing the icinga2_install and icinga2_configure tags. Drop the icinga2_service tag since the service task is a single cheap step and reloads are already covered by the handler chain.
Contributor
Author
|
I will test this PR and give feedback. |
Dynamic include_tasks does not push tags down to the tasks it expands, so --tags icinga2_install and --tags icinga2_configure fired the include statements but then filtered out every child task, leaving the role a no-op under either tag. Add apply: tags: to the two includes so the tag is inherited by install.yml, configure.yml and everything they pull in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose icinga2_install, icinga2_configure and icinga2_service tags on the top-level includes so playbooks can re-run individual phases without rolling out the full role. Fact gathering and OS-specific variable loading are marked as always so the tagged runs still have the required context.