Add Grafana module to Icinga Web role - #494
Open
0uLoL wants to merge 3 commits into
Open
Conversation
Donien
requested changes
Aug 21, 2026
Donien
left a comment
Donien
left a comment
Member
There was a problem hiding this comment.
There's a few things I'd like to see adjusted slightly.
Regarding its function, this PR looks good to me 👍🏻
Comment on lines
+28
to
+37
| config: | ||
| grafana: | ||
| host: grafana.example.org:3000 | ||
| protocol: https | ||
| datasource: icinga-influxdb | ||
| accessmode: direct | ||
| graphs: | ||
| Load: | ||
| dashboarduid: icinga-load | ||
| panelId: "1,2,3" |
Member
There was a problem hiding this comment.
Same here regarding UIDs. Also, datasource is the datasource type, e.g. influxdb or graphite.
How did you end up with accessmode: direct?
I only know of indirectproxy and iframe.
| assert config.contains('host = "grafana.example.org:3000"') | ||
| assert config.contains('protocol = "https"') | ||
| assert config.contains('datasource = "icinga-influxdb"') | ||
| assert config.contains('accessmode = "direct"') |
Member
There was a problem hiding this comment.
This accessmode probably needs to be changed as well.
| assert config.contains('accessmode = "direct"') | ||
|
|
||
| assert graphs.is_file | ||
| assert graphs.contains("[Load]") |
Member
There was a problem hiding this comment.
Also, please keep load in lowercase, simply to avoid confusion as to why the first letter is capitalized.
|
|
||
| assert graphs.is_file | ||
| assert graphs.contains("[Load]") | ||
| assert graphs.contains('dashboarduid = "icinga-load"') |
Member
There was a problem hiding this comment.
Please use a real UID here instead of icinga-load (also, just to avoid confusion)
Co-authored-by: Donien <88634789+Donien@users.noreply.github.com>
0uLoL
force-pushed
the
feature/icingaweb2-grafana-277
branch
from
August 24, 2026 07:43
69cf543 to
9d4fcc1
Compare
0uLoL
force-pushed
the
feature/icingaweb2-grafana-277
branch
from
August 24, 2026 07:49
9d4fcc1 to
b5b9355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
Summary
Adds Grafana module support to the
icingaweb2role.icinga-grafanapackageconfig.iniandgraphs.iniTesting
ansible-galaxy collection build --forcemolecule test -s default