Rewrite in Golang#2
Conversation
Co-authored-by: Christoph Breit <christoph.breit@netways.de>
|
|
||
| msg := fmt.Sprintf("Registered on network '%s' with signal strength %0.f%%", network, sigproc) | ||
|
|
||
| result.Output = msg |
There was a problem hiding this comment.
why not just result.Output = fmt.Sprinf....?
There was a problem hiding this comment.
because sometimes i have to add additional info to the message string I wanted to reuse it instead of having it multiple times.
There was a problem hiding this comment.
I'm a bit confused on why we set the msg twice? And why only in the warning state?
msg := fmt.Sprintf("Registered on network '%s' with signal strength %0.f%%", network, sigproc)
result.SetOutput(msg)
....
else if warningThreshold.DoesViolate(sigproc) {
result.SetState(check.Warning)
result.SetOutput(msg)
|
Why move the files to the |
True. We've done this before, I think so that the old code is more visible. We can still remove it at some point |
|
Hint, I added our default Github Config to the branch |
Co-authored-by: Markus Opolka <markus.opolka@netways.de>
3 participants
No description provided.