DSTA-661: refactored scrape script - #68
Open
wlyagoba wants to merge 2 commits into
Open
Conversation
Signed-off-by: wlyagoba <william.lyagoba1@nhs.net>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the scrape/export script’s progress output to better reflect Databricks write activity by adding total table counts and per-table progress indicators.
Changes:
- Compute the total number of cache tables and include it in the “Writing … tables” message.
- Add a per-table progress prefix (
[i/total]) to the per-table export log line.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
samw-nhs
reviewed
Aug 28, 2026
samw-nhs
left a comment
samw-nhs
left a comment
Contributor
There was a problem hiding this comment.
Are any changes required to either the readme in this folder or the high level readme related to this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored scrape script to push data to databricks
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.