Skip to content

Revert "Added composite id optin flow updated the python and modifed the test…" #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghuramg753 merged 3 commits into from
Mar 6, 2026
Merged

Revert "Added composite id optin flow updated the python and modifed the test…" #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea5e0d4
Revert "Added composite id optin flow updated the python and modifed …
Mar 6, 2026
d869450
upgraded python and test cases.
raghuramg753 Mar 6, 2026
645289a
updated to fix lint errors.
raghuramg753 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 71 additions & 81 deletions poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 0 additions & 9 deletions proxies/live/apiproxy/policies/AM-Enable-DelegatedAccess.xml
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions proxies/live/apiproxy/policies/FlowCallout.CompositeTokenCheckOptIN.xml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions proxies/live/apiproxy/policies/JavaScript.ValidateNHSNumber.xml
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions proxies/live/apiproxy/policies/RaiseFault.401InvalidNHSNumber.xml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions proxies/live/apiproxy/proxies/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,6 @@
<Step>
<Name>FlowCallout.GetEnvironmentKeyValueMapData</Name>
</Step>
<Step>
<Name>AM-Enable-DelegatedAccess</Name>
</Step>
<Step>
<Name>FlowCallout.CompositeTokenCheckOptIN</Name>
<Condition>not (proxy.pathsuffix MatchesPath "/_ping" or proxy.pathsuffix MatchesPath "/_status")</Condition>
</Step>
<Step>
<Name>JavaScript.ValidateNHSNumber</Name>
<Condition>not (proxy.pathsuffix MatchesPath "/_ping" or proxy.pathsuffix MatchesPath "/_status")</Condition>
</Step>
<Step>
<Name>RaiseFault.401InvalidNHSNumber</Name>
<Condition>(trigger.raiseNHSNumberFault = true)</Condition>
</Step>
</Request>
</PreFlow>
<Flows>
Expand Down
25 changes: 0 additions & 25 deletions proxies/live/apiproxy/resources/jsc/ValidateNHSNumber.js
View file
Open in desktop

This file was deleted.

26 changes: 26 additions & 0 deletions tests/test_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import pytest
import os
from os import getenv
# from .example_loader import load_example

Check warning on line 11 in tests/test_endpoints.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp-connect-user-permissions&issues=AZzDskfyqXgmdKQa8j5C&open=AZzDskfyqXgmdKQa8j5C&pullRequest=133


@pytest.fixture()
Expand Down Expand Up @@ -105,3 +106,28 @@
headers=headers
)
assert resp.status_code == 500


# @pytest.mark.auth

Check warning on line 111 in tests/test_endpoints.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this commented out code. 


See more on https://sonarcloud.io/project/issues?id=NHSDigital_gp-connect-user-permissions&issues=AZzDorC9hgA_KbzegeHY&open=AZzDorC9hgA_KbzegeHY&pullRequest=133
# @pytest.mark.integration
# @pytest.mark.nhsd_apim_authorization(
# {
# "access": "patient",
# "level": "P9",
# "login_form": {"username": "9734644475"}
# }
# )
# def test_prism_returns_external_file(nhsd_apim_proxy_url, nhsd_apim_auth_headers):
# headers = {
# "accept": "*/*",
# "X-Correlation-ID": "11C46F5F-CDEF-4865-94B2-0EE0EDCC26DA",
# "X-Request-ID": "60E0B220-8136-4CA5-AE46-1D97EF59D068"
# }
# headers.update(nhsd_apim_auth_headers)

# resp = requests.get(
# f"{nhsd_apim_proxy_url}/Patient/9000000009",
# headers=headers
# )
# expected_response = load_example("GetResponsePermissionsFull.yaml")
# assert resp.json() == expected_response.get("value")
Loading