Skip to content

Update markdownlint-cli container image - #381

Open
AyobamiH wants to merge 1 commit into
NHSDigital:mainfrom
AyobamiH:chore/update-markdownlint-cli-315
Open

Update markdownlint-cli container image#381
AyobamiH wants to merge 1 commit into
NHSDigital:mainfrom
AyobamiH:chore/update-markdownlint-cli-315

Conversation

@AyobamiH

@AyobamiH AyobamiH commented Aug 28, 2026

Copy link
Copy Markdown

Summary

  • update the pinned markdownlint-cli container from v0.32.2 to v0.49.1
  • retain the immutable image digest pin and move the embedded runtime from Node 16 to Node 24
  • preserve the repository's existing lint policy by disabling only rules introduced after the current baseline
  • convert two bold monitoring labels into real headings so the existing MD036 rule remains enforced

Why

Issue #315 proposed v0.39.0 in January 2024 to remove the deprecated punycode path. Rechecking that choice now found that the v0.39.0 image embeds Node 20, which reached end of life in April 2026. The current v0.49.1 image embeds Node 24 instead.

v0.49.1 initially exposed two existing MD036 findings in practices/observability.md. Those labels were functioning as headings, so this change converts them to semantic level-three headings rather than disabling MD036. Rules added after the repository's v0.32.2 baseline are explicitly disabled to avoid silently changing the wider lint policy.

Testing

  • verified the immutable v0.49.1 digest, CLI version 0.49.1, and embedded Node version 24.18.0
  • compared the old and new configurations across every Markdown file: 40 findings before and after, with none added or removed
  • confirmed the old image reports the punycode path with pending deprecations enabled, while the new image does not under pending or trace deprecations
  • exercised scripts/markdown-check-format.sh through a valid Markdown change and an invalid hard-tab change
  • confirmed the invalid change is rejected with MD010
  • bash -n scripts/markdown-check-format.sh
  • verified a one-commit, two-file diff against current main

Validation: https://github.com/AyobamiH/software-engineering-quality-framework/actions/runs/33161187318

Closes #315

@AyobamiH
AyobamiH requested a review from a team as a code owner August 28, 2026 09:19
@github-actions
github-actions Bot force-pushed the chore/update-markdownlint-cli-315 branch from 897345d to 2f22387 Compare August 28, 2026 09:53
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump markdown-cli to v0.39.0

1 participant