test: wait for source inspector keyboard readiness - #59
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 5.0.2 release run failed intermittently when the source-inspector test sent Escape before the modal effect attached its keyboard handler. Finding the rendered dialog alone does not establish effect readiness.
Wait for focus to reach the close button in the shared test helper. That focus change occurs in the same effect that installs the keyboard handler. This keeps the existing dismissal assertions intact and adds no application changes or fixed delays.
Validation: all 13 source-inspector tests, all 214 unit tests, and lint pass locally. Resolves the failure observed in release run 34336719037; publication remains pending.