Skip to content

test(docs): fix WebKit preview readiness races #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cylop merged 2 commits into from
Sep 9, 2026
Merged

test(docs): fix WebKit preview readiness races #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35fed6d
test(docs): synchronize preview hydration and morph sampling
Cylop Sep 9, 2026
ee71d92
test(docs): retain interrupted morph freeze coverage
Cylop Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion e2e/website/recipes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ test('device lab interrupts a morph from its live geometry without replacing the
})
await page.getByRole('button', { name: 'Landscape' }).click()
await expect(frame).toHaveAttribute('data-morphing', 'true')
await setAnimationsAt(90, false)
// Sample a fixed intermediate presentation so elapsed animation time cannot
// look like a discontinuity across the synchronous click handler.
await setAnimationsAt(90, true)

let releaseNavigation = () => {}
let markNavigationBlocked = () => {}
Expand Down Expand Up @@ -507,6 +509,13 @@ test('device lab interrupts a morph from its live geometry without replacing the

await page.getByRole('button', { name: 'Tablet' }).dispatchEvent('click')
await navigationBlocked
// Correct hold animations remain still when played; an uncancelled original
// morph must advance so the stability assertion below can catch it.
await page.locator('.docs-device-lab').evaluate(async (element) => {
const animations = element.getAnimations({ subtree: true })
for (const animation of animations) animation.play()
await Promise.all(animations.map((animation) => animation.ready))
})
await page.waitForTimeout(80)
const heldPresentation = await readGeometry()
const blockedPresentation = await page.evaluate(() => {
Expand Down Expand Up @@ -1207,6 +1216,10 @@ test(
async ({ page }) => {
await page.emulateMedia({ reducedMotion: 'reduce' })
await page.goto('/examples/reduced-motion/')
await expect(page.locator('.docs-device-frame')).toHaveAttribute(
'data-preview-ready',
'true',
)
const frame = recipeFrame(page)
const trigger = frame.getByRole('button', {
name: 'Open reduced-motion sheet',
Expand Down Expand Up @@ -1688,6 +1701,10 @@ test(
async ({ page }) => {
await page.setViewportSize({ width: 1440, height: 900 })
await page.goto('/examples/basic/?device=phone&orientation=portrait')
await expect(page.locator('.docs-device-frame')).toHaveAttribute(
'data-preview-ready',
'true',
)
const iframe = page.locator('[title$="interactive preview"]')
const iframeElement = await iframe.elementHandle()
expect(iframeElement).not.toBeNull()
Expand Down
Loading