Skip to content

fix(docker-compose): rm hard coded gcp service account for ENV #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerAdamMartinez merged 1 commit into from
Aug 18, 2026
Merged

fix(docker-compose): rm hard coded gcp service account for ENV #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/services/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
BUCKET_NAME = os.getenv("GCP_BUCKET_NAME", "")
PHOTO_PREFIX = os.getenv("GCP_PHOTO_PREFIX", "")
PHOTO_JWT_EXPIRE_SECONDS = 600
TARGET_SERVICE_ACCOUNT = (
"pvacd-meterapp@waterdatainitiative-271000.iam.gserviceaccount.com"
)
TARGET_SERVICE_ACCOUNT = os.getenv("GCP_SERVICE_ACCOUNT", "")


def get_activity_photo_record(
Expand Down
1 change: 1 addition & 0 deletions docker-compose.development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ services:
- GCP_WOODPECKER_BUCKET_NAME=meter-manager-woodpecker-bucket
- GCP_BACKUP_PREFIX=pre-prod-db-backups
- GCP_PHOTO_PREFIX=pre-prod-meter-activities-photos
- GCP_SERVICE_ACCOUNT=13393509252-compute@developer.gserviceaccount.com
- BACKUP_RETENTION_DAYS=14
- APPDB_ENV=.env_devserver
command: >
Expand Down
1 change: 1 addition & 0 deletions docker-compose.production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ services:
- GCP_WOODPECKER_BUCKET_NAME=meter-manager-woodpecker-bucket
- GCP_BACKUP_PREFIX=prod-db-backups
- GCP_PHOTO_PREFIX=prod-meter-activities-photos
- GCP_SERVICE_ACCOUNT=13393509252-compute@developer.gserviceaccount.com
- BACKUP_RETENTION_DAYS=90
- APPDB_ENV=.env_production
command: >
Expand Down
Loading