Update MHS QC filters - #2196
Open
jianjunj wants to merge 2 commits into
Open
Conversation
jianjunj
changed the title
JingCheng-NOAA
approved these changes
Jul 27, 2026
CoryMartin-NOAA
approved these changes
Jul 27, 2026
Contributor
Author
|
Thank you @JingCheng-NOAA for informing me the bug and working with me to fix it. Just leave another note: The "max_exclusive" function in the "where" filter are unable to exclude the max_value in functions. That was why we had values divided by zeros in some newly defined functions here. |
|
No problem @jianjunj . Thanks for helping us to solve this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(1) Activated observational data thinning within thinning grid sizes of 145 km.
(2) Added filters to make diff_300_obs2 >= 1e-5 and inflationFactor0 >= 1e-5, ensuring there are no functions divided by zeros.
Companion PRs
Issues
Automated CI tests to run in Global Workflow