Skip to content

Bugfix/filter ps - #2201

Open
ClaraDraper-NOAA wants to merge 3 commits into
developfrom
bugfix/filter_ps
Open

Bugfix/filter ps#2201
ClaraDraper-NOAA wants to merge 3 commits into
developfrom
bugfix/filter_ps

Conversation

@ClaraDraper-NOAA

@ClaraDraper-NOAA ClaraDraper-NOAA commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Explicitly exclude stationPressure obs not being assimilated.

I have also added code to discard the T2m obs in adpsfc until we're ready to include them in the parallel tests.

Companion PRs

N/A

Issues

Resolves 2202

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C48_ufsenkf_atmDA
  • C96C48_hybatmDA

Copilot AI review requested due to automatic review settings August 3, 2026 18:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JCB-GDAS prepbufr observation templates to add additional obs prior filters aimed at filtering surface/upper-air station pressure observation types earlier in the UFO pipeline.

Changes:

  • Add RejectList obs-type pre-filters for stationPressure in prepbufr_sfcshp, prepbufr_adpupa, and prepbufr_adpsfc.
  • Add a “TEMPORARY” block intended to reject all airTemperature obs in prepbufr_adpsfc (currently implemented as a RejectList without where:).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
parm/jcb-gdas/observations/atmosphere/prepbufr_sfcshp.yaml.j2 Adds a RejectList pre-filter for stationPressure obs types.
parm/jcb-gdas/observations/atmosphere/prepbufr_adpupa.yaml.j2 Adds a RejectList pre-filter for stationPressure obs types.
parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2 Adds a RejectList pre-filter for stationPressure obs types and introduces a new airTemperature rejection block.
Suppressed comments (1)

parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2:420

  • This RejectList block has no where: clause, which is inconsistent with other RejectList usage in this repo and is likely invalid configuration (or at best ambiguous). If the intent is to reject all airTemperature observations, use a Perform Action filter with action: reject so the behavior is explicit and schema-compliant.
  # TEMPORARY: REJECT ALL T OBS
  - filter: RejectList
    filter variables:
    - name: airTemperature

Comment thread parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2
@ClaraDraper-NOAA ClaraDraper-NOAA self-assigned this Aug 3, 2026
@ClaraDraper-NOAA

Copy link
Copy Markdown
Collaborator Author

Comparison of Ps obs errors after PR:

Ps_error_fixed_both

Comparison of Ps obs error before PR:
Ps_error_orig

@ClaraDraper-NOAA

ClaraDraper-NOAA commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-07-31 at 4 56 28 PM

Difference between GSI and JEDI surface pressure increment, before and after PR - for assimilation of adpsfc Ps.

Comment thread parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually add the changes from the PR to the WCOSS2 prjedi $HOMEglobal/sorc/gdas.cd/parm/jcb-gdas/observations/atmosphere/

Test changes in 2026080312 gdas cycle. Initial run of gdas_atmanlinit failed while rendering prepbufr_adpsfc.yaml.j2. See comment for additional detail. gdas_atmanlinit ran to completion after making a small change to prepbufr_adpsfc.yaml.j2.

Will run label-based GDASApp CI on Ursa. It's possible some reference test files will need to be updated since this PR changes which ps observations are assimilated.

@emcbot

emcbot commented Aug 3, 2026

Copy link
Copy Markdown

Automated GW-GDASApp Testing Results:
Machine: ursa

Start: Mon Aug  3 19:48:57 UTC 2026 on ufe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Aug  3 20:03:03 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Mon Aug  3 21:02:43 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Most pressure obs are counted twice when inflating obs errors for duplicates.

5 participants