Bugfix/filter ps - #2201
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the JCB-GDAS prepbufr observation templates to add additional obs prior filters aimed at filtering surface/upper-air station pressure observation types earlier in the UFO pipeline.
Changes:
- Add
RejectListobs-type pre-filters forstationPressureinprepbufr_sfcshp,prepbufr_adpupa, andprepbufr_adpsfc. - Add a “TEMPORARY” block intended to reject all
airTemperatureobs inprepbufr_adpsfc(currently implemented as aRejectListwithoutwhere:).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parm/jcb-gdas/observations/atmosphere/prepbufr_sfcshp.yaml.j2 | Adds a RejectList pre-filter for stationPressure obs types. |
| parm/jcb-gdas/observations/atmosphere/prepbufr_adpupa.yaml.j2 | Adds a RejectList pre-filter for stationPressure obs types. |
| parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2 | Adds a RejectList pre-filter for stationPressure obs types and introduces a new airTemperature rejection block. |
Suppressed comments (1)
parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2:420
- This
RejectListblock has nowhere:clause, which is inconsistent with otherRejectListusage in this repo and is likely invalid configuration (or at best ambiguous). If the intent is to reject allairTemperatureobservations, use aPerform Actionfilter withaction: rejectso the behavior is explicit and schema-compliant.
# TEMPORARY: REJECT ALL T OBS
- filter: RejectList
filter variables:
- name: airTemperature
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Manually add the changes from the PR to the WCOSS2 prjedi $HOMEglobal/sorc/gdas.cd/parm/jcb-gdas/observations/atmosphere/
Test changes in 2026080312 gdas cycle. Initial run of gdas_atmanlinit failed while rendering prepbufr_adpsfc.yaml.j2. See comment for additional detail. gdas_atmanlinit ran to completion after making a small change to prepbufr_adpsfc.yaml.j2.
Will run label-based GDASApp CI on Ursa. It's possible some reference test files will need to be updated since this PR changes which ps observations are assimilated.
|
Automated GW-GDASApp Testing Results: |



Description
Explicitly exclude stationPressure obs not being assimilated.
I have also added code to discard the T2m obs in adpsfc until we're ready to include them in the parallel tests.
Companion PRs
N/A
Issues
Resolves 2202
Automated CI tests to run in Global Workflow